Skip to content

fix: chronicle start runs Nitro production server#76

Draft
rsbh wants to merge 1 commit into
mainfrom
fix/start-nitro
Draft

fix: chronicle start runs Nitro production server#76
rsbh wants to merge 1 commit into
mainfrom
fix/start-nitro

Conversation

@rsbh
Copy link
Copy Markdown
Member

@rsbh rsbh commented May 15, 2026

Summary

chronicle start was using Vite preview() — a static file server that doesn't run Nitro SSR, API routes, or search. Now it spawns node .output/server/index.mjs (the actual Nitro production server).

Before

  • Used Vite preview (static files only)
  • No SSR, no API routes, no search
  • allowedHosts errors in Docker

After

  • Runs Nitro production server
  • Full SSR + API routes + search
  • Checks build exists, clear error message if not
  • Forwards PORT/HOST env vars
  • Signal forwarding to child process

Test plan

  • chronicle build && chronicle start — full SSR works
  • API routes (/api/search, /api/health) respond
  • Ctrl+C stops the server
  • Without build → shows "Run chronicle build first" error

🤖 Generated with Claude Code

@vercel
Copy link
Copy Markdown

vercel Bot commented May 15, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
chronicle Ready Ready Preview, Comment May 15, 2026 7:42am

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 54abd9c0-301e-4ea4-8cac-bac81a7d7dbc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/start-nitro

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rsbh rsbh force-pushed the fix/start-nitro branch from 6798b4d to 70dce65 Compare May 15, 2026 05:50
@rsbh rsbh force-pushed the fix/start-nitro branch from 70dce65 to 94be7ad Compare May 15, 2026 05:55
@rsbh rsbh force-pushed the fix/start-nitro branch from 94be7ad to 57dd89a Compare May 15, 2026 05:56
@rsbh rsbh marked this pull request as draft May 15, 2026 05:56
@rsbh rsbh force-pushed the fix/start-nitro branch from 57dd89a to cda92e2 Compare May 15, 2026 07:38
@rsbh @claude
fix: chronicle start runs Nitro production server instead of Vite pre…
0d9463a 
…view

Replace Vite preview() with spawning node .output/server/index.mjs
for proper SSR, API routes, and search in production. Checks build
exists, forwards signals to child process.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@rsbh rsbh force-pushed the fix/start-nitro branch from cda92e2 to 0d9463a Compare May 15, 2026 07:42
@rsbh rsbh requested a review from rohilsurana May 15, 2026 07:49
rohilsurana
rohilsurana reviewed May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@rohilsurana rohilsurana left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues

  1. serve command is now inconsistent — serve.ts still uses Vite preview() (build + preview). After this PR, serve (build+start) and build && start will behave differently: serve won't have SSR/API routes, but start will. serve should be updated to call the same Nitro spawn logic, or be deprecated.

  2. Vercel preset path assumption — resolveServerEntry hardcodes .vercel/output/server/index.mjs. Vercel's serverless output doesn't produce a standalone index.mjs you can node-run directly — its output is designed for Vercel's runtime. Running chronicle start --preset vercel would likely fail silently or with a confusing error. Consider either validating the preset isn't a serverless target, or dropping Vercel from start and only supporting it in build.

Minor

  1. configPath and linkContent are now unused — loadCLIConfig still returns configPath and config, but the new code doesn't call linkContent. This is fine for start (content was linked at build time), but worth a comment or removing the unused destructured variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohilsurana rohilsurana rohilsurana left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rsbh @rohilsurana